carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 14:41:06 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove verbose formatting of instructions on crash messages. (#4495)

Browse Source 
Undoes a chunk of #4125 because nobody's really in favor of keeping the
formatting, and it's occasionally caused a crash in Formatter to
dominate output (and even when working, it can be verbose; the source
location in (5) is often more helpful).

Basically goes back to:

```
4.	Check::Context
          NodeStack:
            0. LetIntroducer: no value
            1. BindingPattern: inst+15
            2. LetInitializer: no value
            3. StructLiteralStart: no value
          inst_block_stack_:
            0.	block<invalid>	{inst+0, inst+1, inst+6, inst+7, inst+8, inst+9, inst+10, inst+11, inst+12}
            1.	global_init	{}
          pattern_block_stack_:
            0.	block<invalid>	{}
          param_and_arg_refs_stack:
            0.	block<invalid>	{}
          args_type_info_stack_:
            0.	block<invalid>	{}
5.	alias_of_alias.carbon:15:12: checking StructLiteral
          let d: c = {};
                     ^~
```

Fixes #4145
This commit is contained in:
Jon Ross-Perkins
2024-11-07 16:22:36 +00:00
committed by GitHub
parent be56ff87c6
commit 138ecf108f
9 changed files with 32 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/inst_block_stack.cpp
+7 -5
View File
@@ -61,17 +61,19 @@ auto InstBlockStack::PopAndDiscard() -> void {
CARBON_VLOG("{0} PopAndDiscard {1}\n", name_, id_stack_.size());
}
auto InstBlockStack::PrintForStackDump(SemIR::Formatter& formatter, int indent,
auto InstBlockStack::PrintForStackDump(int indent,
llvm::raw_ostream& output) const
-> void {
output.indent(indent);
output << name_ << ":\n";
for (const auto& [i, id] : llvm::enumerate(id_stack_)) {
output.indent(indent + 2);
output << i << ". " << id;
formatter.PrintPartialTrailingCodeBlock(insts_stack_.PeekArrayAt(i),
indent + 4, output);
output << "\n";
output << i << ".\t" << id << "\t{";
llvm::ListSeparator sep;
for (auto id : insts_stack_.PeekArrayAt(i)) {
output << sep << id;
}
output << "}\n";
}
}