mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 07:18:11 +00:00
[Carbon/C++ interop] Add support for C++ overloaded functions (#5891)
As proposed in [Carbon: C++ interop for overloaded functions and function templates](https://docs.google.com/document/d/1KUxumZtNe3mY3TsjW2s_ZADOlAaFlrtsLKHVILtqIaM/edit?tab=t.0), Clang is used to perform the overload resolution using C++ rules, when an overloaded C++ set is called from Carbon. Once a function is selected, it's converted into a Carbon function and called using the Carbon rules including argument conversions. A single non-templated function is treated the same way as an overload set and the same rules apply for its call. Template functions are not supported yet. Demo: a) Non-templated function calls: ```c++ // --- overloads.h auto foo(int a, short b) -> void; auto foo(double a) -> void; auto foo(int a) -> void; ``` ```c++ // overloads.cpp #include "overloads.h" #include <cstdio> auto foo(int a, short b) -> void { printf("hello from foo_int_short(%d, %d) \n", a, b); } auto foo(double a) -> void { printf("hello from foo_double(%f) \n", a); } auto foo(int a) -> void { printf("hello from foo_int(%d) \n", a); } ``` ```c++ library "Main"; import Cpp library "overloads.h"; fn Run() -> i32 { Cpp.foo(1.1 as f64); return 0; } ``` ``` $ clang -c overloads.cpp $ bazel-bin/toolchain/carbon compile main.carbon $ bazel-bin/toolchain/carbon link overloads.o main.o --output=demo $ ./demo hello from foo_double(1.100000) ``` b) Constructors: ```c++ // --- constructor_overloads.h class C { public: C(); C(int a, int b); }; ``` ```c++ // constructor_overloads.cpp #include "constructor_overloads.h" #include <cstdio> C::C() { printf("hello from C() \n"); } C::C(int a, int b) { printf("hello from C(%d, %d) \n", a, b); } ``` ```c++ library "Main"; import Cpp library "constructor_overloads.h"; fn Run() -> i32 { let c1: Cpp.C = Cpp.C.C(); let c2: Cpp.C = Cpp.C.C(1, 2); return 0; } ``` ``` $ clang -c constructor_overloads.cpp $ bazel-bin/toolchain/carbon compile main.carbon $ bazel-bin/toolchain/carbon link constructor_overloads.o main.o \--output=demo $ ./demo hello from C() hello from C(1, 2) ``` Follow-ups: - `Cpp.foo({})` - proper handling of struct literals as call args. - Fix access for overloaded sets. - Fix tests: - Method calls: `error: missing object argument in method call [MissingObjectInMethodCall]` in tests. - Fix `toolchain/check/testdata/interop/cpp/import.carbon` test. - Fix `enums` support. - Fix `str` -> `std::string_view` mapping. Part of #5915
This commit is contained in:
1 parent
20ac6b9270
commit
12ddfb9c7c
61 files changed
+4633
-2252
No files matched your search
@@ -0,0 +1,124 @@
|
||||
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
||||
// Exceptions. See /LICENSE for license information.
|
||||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
||||
|
||||
#include "toolchain/check/cpp_overload_resolution.h"
|
||||
|
||||
#include "clang/Sema/Overload.h"
|
||||
#include "clang/Sema/Sema.h"
|
||||
#include "toolchain/check/cpp_type_mapping.h"
|
||||
#include "toolchain/check/import_cpp.h"
|
||||
|
||||
namespace Carbon::Check {
|
||||
|
||||
auto PerformCppOverloadResolution(Context& context, SemIR::LocId loc_id,
|
||||
SemIR::InstId callee_id,
|
||||
llvm::ArrayRef<SemIR::InstId> arg_ids)
|
||||
-> std::optional<SemIR::InstId> {
|
||||
Diagnostics::AnnotationScope annotate_diagnostics(
|
||||
&context.emitter(), [&](auto& builder) {
|
||||
CARBON_DIAGNOSTIC(InCallToCppFunction, Note,
|
||||
"in call to Cpp function here");
|
||||
builder.Note(loc_id, InCallToCppFunction);
|
||||
});
|
||||
|
||||
// Map Carbon call argument types to C++ types.
|
||||
llvm::SmallVector<clang::Expr*> arg_exprs;
|
||||
arg_exprs.reserve(arg_ids.size());
|
||||
for (SemIR::InstId arg_id : arg_ids) {
|
||||
clang::QualType arg_cpp_type = MapToCppType(context, arg_id);
|
||||
if (arg_cpp_type.isNull()) {
|
||||
CARBON_DIAGNOSTIC(CppCallArgTypeNotSupported, Error,
|
||||
"call argument of type {0} is not supported",
|
||||
TypeOfInstId);
|
||||
context.emitter().Emit(loc_id, CppCallArgTypeNotSupported, arg_id);
|
||||
return std::nullopt;
|
||||
}
|
||||
// TODO: Allocate these on the stack.
|
||||
arg_exprs.emplace_back(new (context.ast_context()) clang::OpaqueValueExpr(
|
||||
// TODO: Add location accordingly.
|
||||
clang::SourceLocation(), arg_cpp_type.getNonReferenceType(),
|
||||
clang::ExprValueKind::VK_LValue));
|
||||
}
|
||||
|
||||
auto overload_set_type =
|
||||
context.types()
|
||||
.GetAsInst(context.insts().Get(callee_id).type_id())
|
||||
.TryAs<SemIR::CppOverloadSetType>();
|
||||
// TODO: CHECK-fail or store CppOverloadSetId in the CalleeFunction and pass
|
||||
// it in here.
|
||||
if (!overload_set_type) {
|
||||
return std::nullopt;
|
||||
}
|
||||
const SemIR::CppOverloadSet& overload_set =
|
||||
context.cpp_overload_sets().Get(overload_set_type->overload_set_id);
|
||||
|
||||
// Add candidate functions from the name lookup.
|
||||
clang::OverloadCandidateSet candidate_set(
|
||||
// TODO: Add location accordingly.
|
||||
clang::SourceLocation(),
|
||||
clang::OverloadCandidateSet::CandidateSetKind::CSK_Normal);
|
||||
|
||||
clang::ASTUnit* ast = context.sem_ir().clang_ast_unit();
|
||||
CARBON_CHECK(ast);
|
||||
clang::Sema& sema = ast->getSema();
|
||||
|
||||
// TODO: Add support for method calls.
|
||||
for (clang::NamedDecl* candidate : overload_set.candidate_functions) {
|
||||
if (auto* fn_decl = dyn_cast<clang::FunctionDecl>(candidate)) {
|
||||
sema.AddOverloadCandidate(
|
||||
fn_decl, clang::DeclAccessPair::make(fn_decl, candidate->getAccess()),
|
||||
arg_exprs, candidate_set);
|
||||
} else if (isa<clang::FunctionTemplateDecl>(candidate)) {
|
||||
CARBON_DIAGNOSTIC(CppTemplateFunctionNotSupported, Error,
|
||||
"template function is not supported");
|
||||
context.emitter().Emit(loc_id, CppTemplateFunctionNotSupported);
|
||||
return std::nullopt;
|
||||
}
|
||||
// TODO: Diagnose if it's neither of these types.
|
||||
}
|
||||
|
||||
// Find best viable function among the candidates.
|
||||
clang::OverloadCandidateSet::iterator best_viable_fn;
|
||||
clang::OverloadingResult overloading_result =
|
||||
// TODO: Add location accordingly.
|
||||
candidate_set.BestViableFunction(sema, clang::SourceLocation(),
|
||||
best_viable_fn);
|
||||
|
||||
switch (overloading_result) {
|
||||
case clang::OverloadingResult::OR_Success: {
|
||||
// TODO: Handle the cases when Function is null.
|
||||
CARBON_CHECK(best_viable_fn->Function);
|
||||
SemIR::InstId result =
|
||||
ImportCppFunctionDecl(context, loc_id, best_viable_fn->Function);
|
||||
return result;
|
||||
}
|
||||
case clang::OverloadingResult::OR_No_Viable_Function: {
|
||||
// TODO: Add notes with the candidates.
|
||||
CARBON_DIAGNOSTIC(CppOverloadingNoViableFunctionFound, Error,
|
||||
"no matching function for call to `{0}`",
|
||||
SemIR::NameId);
|
||||
context.emitter().Emit(loc_id, CppOverloadingNoViableFunctionFound,
|
||||
overload_set.name_id);
|
||||
return std::nullopt;
|
||||
}
|
||||
case clang::OverloadingResult::OR_Ambiguous: {
|
||||
// TODO: Add notes with the candidates.
|
||||
CARBON_DIAGNOSTIC(CppOverloadingAmbiguousCandidatesFound, Error,
|
||||
"call to `{0}` is ambiguous", SemIR::NameId);
|
||||
context.emitter().Emit(loc_id, CppOverloadingAmbiguousCandidatesFound,
|
||||
overload_set.name_id);
|
||||
return std::nullopt;
|
||||
}
|
||||
case clang::OverloadingResult::OR_Deleted: {
|
||||
// TODO: Add notes with the candidates.
|
||||
CARBON_DIAGNOSTIC(CppOverloadingDeletedFunctionFound, Error,
|
||||
"call to deleted function `{0}`", SemIR::NameId);
|
||||
context.emitter().Emit(loc_id, CppOverloadingDeletedFunctionFound,
|
||||
overload_set.name_id);
|
||||
return std::nullopt;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
} // namespace Carbon::Check
|
||||
Reference in new issue
Block a user