carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Let lldb dump display a variable when its name matches an id type name (#7148)

Browse Source 
`dump context facet_type` was an error before since we expected that to
be followed with an id value. While `dump context facet_type 5` still
works, if there's no id value, try to use `facet_type` as a variable
name. This allows us to dump an inst id if it happens to be named
`inst`, etc, without having to use `--` to disambiguate.
This commit is contained in:
Dana Jansens
2026-05-01 15:09:45 +00:00
committed by GitHub
parent 62b94f7932
commit 110adf15c2
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/lldbinit.py
+10 -8
View File
@@ -118,7 +118,7 @@ Example usage:
# Look for <type><id> as a single argument.
if m := re.fullmatch("([a-z_]+)(?:0x)?([0-9A-Fa-f]+)", args[1]):
if m[1] in id_types:
if len(args) != 2:
if len(args) > 2:
print_usage()
return
make_id_fn = id_types[m[1]]
@@ -126,16 +126,18 @@ Example usage:
print_dump(context, f"{make_id_fn}({id})")
found_id_type = True
# Look for <type> <id> as two arguments.
# Look for <type> <id> as two arguments. If there's no <id>, the <type>
# should just be treated as a variable name.
if args[1] in id_types:
if len(args) != 3:
if len(args) > 3:
print_usage()
return
if m := re.fullmatch("(?:0x)?([0-9A-Fa-f]+)", args[2]):
make_id_fn = id_types[args[1]]
id = int(m[1], 16)
print_dump(context, f"{make_id_fn}({id})")
found_id_type = True
elif len(args) == 3:
if m := re.fullmatch("(?:0x)?([0-9A-Fa-f]+)", args[2]):
make_id_fn = id_types[args[1]]
id = int(m[1], 16)
print_dump(context, f"{make_id_fn}({id})")
found_id_type = True
if not found_id_type:
# Use `--` to escape a variable name like `inst22`.