carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 10:54:49 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Cleanup pass over llvm::seq uses (#5185)

Browse Source 
I was thinking about this after `seq` changes in #5182, and looked for
other uses that might be replaceable. Here's the resulting cleanup
around `seq`:

- Switch to `enumerate` or `zip` when possible.
- `int _` -> `auto _` (it's typically a `size_t`, but there's no reason
to cast when unused)
- Fix a case of cast style `(size_t)...` -> `static_cast<size_t>(...)`
- Switch `(void)close_children_count` to `[[maybe_unused]]`
This commit is contained in:
Jon Ross-Perkins
2025-03-26 19:25:03 +00:00
committed by GitHub
parent acbe6530c3
commit 0d3d829478
9 changed files with 37 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/driver/compile_benchmark.cpp
+4 -4
View File
@@ -34,10 +34,10 @@ class CompileBenchmark {
auto SetUpFiles(llvm::ArrayRef<std::string> sources)
-> llvm::OwningArrayRef<std::string> {
llvm::OwningArrayRef<std::string> file_names(sources.size());
for (ssize_t i : llvm::seq<ssize_t>(sources.size())) {
file_names[i] = llvm::formatv("file_{0}.carbon", i).str();
fs_->addFile(file_names[i], /*ModificationTime=*/0,
llvm::MemoryBuffer::getMemBuffer(sources[i]));
for (auto [i, source, file_name] : llvm::enumerate(sources, file_names)) {
file_name = llvm::formatv("file_{0}.carbon", i).str();
fs_->addFile(file_name, /*ModificationTime=*/0,
llvm::MemoryBuffer::getMemBuffer(source));
}
return file_names;
}