carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 08:44:41 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Fix the clang-tidy naming settings. (#219)

Browse Source 
The term "constant" in this setting seems to actually mean anything that
is `const` qualified. For Carbon code, anything that should actually use
`CamelCase` should also use `constexpr` which has its own naming setting
and is correct. With this setting change and making a test variable
`constexpr`, clang-tidy is happy with all the names.
This commit is contained in:
Chandler Carruth
2020-12-08 02:07:06 -08:00
committed by GitHub
parent 27386db279
commit 0c34e65c1c
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lexer/tokenized_buffer_test.cpp
+1 -1
View File
@@ -116,7 +116,7 @@ TEST_F(LexerTest, HandlesIntegerLiteral) {
}
TEST_F(LexerTest, HandlesGarbageCharacters) {
const char GarbageText[] = "$$💩-$\n$\0$12$";
constexpr char GarbageText[] = "$$💩-$\n$\0$12$";
auto buffer = Lex(llvm::StringRef(GarbageText, sizeof(GarbageText) - 1));
EXPECT_TRUE(buffer.HasErrors());
EXPECT_THAT(