carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove the type field from semantics nodes that don't produce values of that type. (#3049)

Browse Source 
For `Assign` and `ReturnExpression`, this field wasn't used for
anything. For `StructTypeField`, we stored the type of the field here,
and now store it as an argument of the node instead.

---------

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
This commit is contained in:
Richard Smith
2023-08-02 17:30:27 +00:00
committed by GitHub
co-authored by Jon Ross-Perkins
parent ab709b4117
commit 0c33dead70
71 changed files with 170 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/testdata/basics/builtin_types.carbon
Vendored
+4 -4
View File
@@ -30,18 +30,18 @@
// CHECK:STDOUT: {kind: VarStorage, type: type0},
// CHECK:STDOUT: {kind: BindName, arg0: str0, arg1: node+0, type: type0},
// CHECK:STDOUT: {kind: IntegerLiteral, arg0: int0, type: type0},
// CHECK:STDOUT: {kind: Assign, arg0: node+0, arg1: node+2, type: type0},
// CHECK:STDOUT: {kind: Assign, arg0: node+0, arg1: node+2},
// CHECK:STDOUT: {kind: VarStorage, type: type1},
// CHECK:STDOUT: {kind: BindName, arg0: str1, arg1: node+4, type: type1},
// CHECK:STDOUT: {kind: RealLiteral, arg0: real0, type: type1},
// CHECK:STDOUT: {kind: Assign, arg0: node+4, arg1: node+6, type: type1},
// CHECK:STDOUT: {kind: Assign, arg0: node+4, arg1: node+6},
// CHECK:STDOUT: {kind: VarStorage, type: type2},
// CHECK:STDOUT: {kind: BindName, arg0: str2, arg1: node+8, type: type2},
// CHECK:STDOUT: {kind: StringLiteral, arg0: str3, type: type2},
// CHECK:STDOUT: {kind: Assign, arg0: node+8, arg1: node+10, type: type2},
// CHECK:STDOUT: {kind: Assign, arg0: node+8, arg1: node+10},
// CHECK:STDOUT: {kind: VarStorage, type: typeTypeType},
// CHECK:STDOUT: {kind: BindName, arg0: str4, arg1: node+12, type: typeTypeType},
// CHECK:STDOUT: {kind: Assign, arg0: node+12, arg1: nodeIntegerType, type: typeTypeType},
// CHECK:STDOUT: {kind: Assign, arg0: node+12, arg1: nodeIntegerType},
// CHECK:STDOUT: ]
// CHECK:STDOUT: node_blocks: [
// CHECK:STDOUT: [
toolchain/semantics/testdata/basics/fail_non_type_as_type.carbon
Vendored
+1 -1
View File
@@ -23,7 +23,7 @@
// CHECK:STDOUT: {kind: VarStorage, type: typeTypeType},
// CHECK:STDOUT: {kind: BindName, arg0: str0, arg1: node+0, type: typeTypeType},
// CHECK:STDOUT: {kind: IntegerLiteral, arg0: int0, type: type0},
// CHECK:STDOUT: {kind: Assign, arg0: node+0, arg1: nodeError, type: typeError},
// CHECK:STDOUT: {kind: Assign, arg0: node+0, arg1: nodeError},
// CHECK:STDOUT: ]
// CHECK:STDOUT: node_blocks: [
// CHECK:STDOUT: [
toolchain/semantics/testdata/basics/fail_qualifier_unsupported.carbon
Vendored
+1 -1
View File
@@ -25,7 +25,7 @@
// CHECK:STDOUT: {kind: BindName, arg0: str0, arg1: node+0, type: type0},
// CHECK:STDOUT: {kind: VarStorage, type: type0},
// CHECK:STDOUT: {kind: BindName, arg0: str1, arg1: node+2, type: type0},
// CHECK:STDOUT: {kind: Assign, arg0: node+2, arg1: nodeError, type: typeError},
// CHECK:STDOUT: {kind: Assign, arg0: node+2, arg1: nodeError},
// CHECK:STDOUT: ]
// CHECK:STDOUT: node_blocks: [
// CHECK:STDOUT: [
toolchain/semantics/testdata/basics/parens.carbon
Vendored
+1 -1
View File
@@ -26,7 +26,7 @@
// CHECK:STDOUT: {kind: IntegerLiteral, arg0: int0, type: type0},
// CHECK:STDOUT: {kind: IntegerLiteral, arg0: int1, type: type0},
// CHECK:STDOUT: {kind: BinaryOperatorAdd, arg0: node+2, arg1: node+3, type: type0},
// CHECK:STDOUT: {kind: Assign, arg0: node+0, arg1: node+4, type: type0},
// CHECK:STDOUT: {kind: Assign, arg0: node+0, arg1: node+4},
// CHECK:STDOUT: ]
// CHECK:STDOUT: node_blocks: [
// CHECK:STDOUT: [