carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 22:02:23 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove the type field from semantics nodes that don't produce values of that type. (#3049)

Browse Source 
For `Assign` and `ReturnExpression`, this field wasn't used for
anything. For `StructTypeField`, we stored the type of the field here,
and now store it as an argument of the node instead.

---------

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
This commit is contained in:
Richard Smith
2023-08-02 17:30:27 +00:00
committed by GitHub
co-authored by Jon Ross-Perkins
parent ab709b4117
commit 0c33dead70
71 changed files with 170 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/semantics_handle_variable.cpp
+2 -3
View File
@@ -31,9 +31,8 @@ auto SemanticsHandleVariableDeclaration(SemanticsContext& context,
auto cast_value_id = context.ImplicitAsRequired(
parse_node, expr_node_id,
context.semantics_ir().GetNode(storage_id).type_id());
context.AddNode(SemanticsNode::Assign::Make(
parse_node, context.semantics_ir().GetNode(cast_value_id).type_id(),
storage_id, cast_value_id));
context.AddNode(
SemanticsNode::Assign::Make(parse_node, storage_id, cast_value_id));
}
context.node_stack()