carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 20:42:01 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove redundant optional wrapping llvm::function_ref (#4367)

Browse Source 
llvm::function_ref (like std::unique_ptr, for instance) already has a
null/empty state, so use that to avoid confusion/duplication of empty
states between optional and the nested function_refs.
This commit is contained in:
David Blaikie
2024-10-07 17:25:35 +00:00
committed by GitHub
parent e38ad83bfd
commit 0b5d1101f9
6 changed files with 28 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/operator.cpp
+6 -8
View File
@@ -29,10 +29,9 @@ static auto GetOperatorOpFunction(Context& context, SemIR::LocId loc_id,
return PerformMemberAccess(context, loc_id, interface_id, op_name_id);
}
auto BuildUnaryOperator(
Context& context, SemIR::LocId loc_id, Operator op,
SemIR::InstId operand_id,
std::optional<Context::BuildDiagnosticFn> missing_impl_diagnoser)
auto BuildUnaryOperator(Context& context, SemIR::LocId loc_id, Operator op,
SemIR::InstId operand_id,
Context::BuildDiagnosticFn missing_impl_diagnoser)
-> SemIR::InstId {
// Look up the operator function.
auto op_fn = GetOperatorOpFunction(context, loc_id, op);
@@ -48,10 +47,9 @@ auto BuildUnaryOperator(
return PerformCall(context, loc_id, bound_op_id, {});
}
auto BuildBinaryOperator(
Context& context, SemIR::LocId loc_id, Operator op, SemIR::InstId lhs_id,
SemIR::InstId rhs_id,
std::optional<Context::BuildDiagnosticFn> missing_impl_diagnoser)
auto BuildBinaryOperator(Context& context, SemIR::LocId loc_id, Operator op,
SemIR::InstId lhs_id, SemIR::InstId rhs_id,
Context::BuildDiagnosticFn missing_impl_diagnoser)
-> SemIR::InstId {
// Look up the operator function.
auto op_fn = GetOperatorOpFunction(context, loc_id, op);