Reimplement destroy as an interface (#5678)

Browse Source

This changes `Destroy` to use an interface for its implementation.

Note that this change includes a lot of test updates. Even when
`Destroy` is a no-op, it still causes code generation as part of
determining that.

Originally I was trying to use ranges to cut down the scope of this, and
to a degree I think they have. But a flipside here is that cases where
no destructors should be generated -- particularly globals -- would be
needed to completely remove destructor calls. Even for ranges, the range
can often include the destructor placement. So I've shifted
frame-of-thought a little: accept a bunch of destructor churn, because
destructors are needed and will be prevalent. The verbosity is a feature
of the design to make desugaring apparent in IR, not a bug.

...

This commit is contained in:

Jon Ross-Perkins

2025-06-27 21:57:14 +00:00

committed by GitHub

parent bba037738d

commit 0722dab0ef

171 changed files with 11900 additions and 1434 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

toolchain/check/testdata/interop/cpp/function_param_int32.carbon

Vendored

+2156

File diff suppressed because it is too large Load Diff