Tweak the name for the function that diagnoses when fuzzing external libraries (#5974)

The old function name caused some confusion during the review of #5338,
sending this to see if it provides a less surprising function name and
boolean result. Happy to try other names / approaches as well.
This commit is contained in:
Chandler Carruth
2025-08-21 19:36:44 +00:00
committed by GitHub
parent 223d0397c0
commit 046fbbcb29
6 changed files with 12 additions and 13 deletions
+4 -5
View File
@@ -10,12 +10,11 @@
namespace Carbon {
auto DriverSubcommand::DisableFuzzingExternalLibraries(DriverEnv& driver_env,
llvm::StringRef name)
-> bool {
auto DriverSubcommand::TestAndDiagnoseIfFuzzingExternalLibraries(
DriverEnv& driver_env, llvm::StringRef name) -> bool {
// Only need to do anything when fuzzing.
if (!driver_env.fuzzing) {
return true;
return false;
}
CARBON_DIAGNOSTIC(
@@ -23,7 +22,7 @@ auto DriverSubcommand::DisableFuzzingExternalLibraries(DriverEnv& driver_env,
"preventing fuzzing of `{0}` subcommand due to external library",
std::string);
driver_env.emitter.Emit(ToolFuzzingDisallowed, name.str());
return false;
return true;
}
} // namespace Carbon