From 03ddeb576b05c3919de3c7c13ff731cb6bfcfee8 Mon Sep 17 00:00:00 2001 From: Jon Ross-Perkins Date: Wed, 23 Oct 2024 11:01:14 -0700 Subject: [PATCH] Fix use of runfiles (#4440) I was looking at the documentation again, and I realized that while this works, I think the intention is that `runfiles` is set _instead_ of both fields (I was a little confused by the error I was getting when setting `runfiles` _with_ `default_runfiles`) I believe I've verified this works in necessary situations. --- bazel/manifest/defs.bzl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bazel/manifest/defs.bzl b/bazel/manifest/defs.bzl index ba5fa6d3a287..9e9bbd65006f 100644 --- a/bazel/manifest/defs.bzl +++ b/bazel/manifest/defs.bzl @@ -20,12 +20,10 @@ def _manifest(ctx): ctx.actions.write(out, "\n".join(content) + "\n") - runfiles = ctx.runfiles(files = [out]) return [ DefaultInfo( files = depset(direct = [out]), - data_runfiles = runfiles, - default_runfiles = runfiles, + runfiles = ctx.runfiles(files = [out]), ), ]